Skip to content

refactor: Fix linting, testing, CI, remove old backends and logs - #32

Merged
bmtcril merged 5 commits into
mainfrom
bmtcril/basic_tests
Jun 27, 2023
Merged

refactor: Fix linting, testing, CI, remove old backends and logs#32
bmtcril merged 5 commits into
mainfrom
bmtcril/basic_tests

Conversation

@bmtcril

@bmtcril bmtcril commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

Long overdue cleanup and basic testing so we can be more confident about requirements updates. Manually tested against all 3 remaining backends successfully.

@bmtcril
bmtcril requested review from Ian2012 and pomegranited June 26, 2023 18:01

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 couple of minor nits, but this this is good to merge once they're addressed or dismissed.

Thank you for culling out the unneeded mongo and citus backends, as well as all of those log files! Leaner and meaner tool now..

  • I tested this by running this branch in my Aspects shell, on both the ralph and clickhouse backends.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation
  • Commit structure follows OEP-0051

Comment thread codecov.yml Outdated
Comment thread setup.py
@@ -29,6 +32,8 @@
license="AGPLv3",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the install_requires for pymongo[srv] and psycopg2-binary too?

Alternatively, borrow this: https://github.com/overhangio/tutor/blob/master/setup.py#L60

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way Tutor does it has some issues with the OeX constraints and version pinning, but I removed those and matched the pinned versions in base.in. I also removed the numpy requirement since it seems like clickhouse-connect no longer throws an error when it's missing, and widened the constraint to <0.7 since it's been running 0.6.4 fine based off of the previous non-pinned versioning in setup.py. I'm not 100% sure this won't break things, but I also version bumped so we can test in the Aspects plugin and roll back if necessary.

Comment thread README.rst

@Ian2012 Ian2012 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with a fresh environment

@bmtcril
bmtcril merged commit 4a5af77 into main Jun 27, 2023
@bmtcril
bmtcril deleted the bmtcril/basic_tests branch June 27, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants