Skip to content

Teak/Ulmo settings and feature toggles diffs - #553

Merged
sarina merged 3 commits into
mainfrom
sarina/ulmo-teak-diff
Dec 10, 2025
Merged

Teak/Ulmo settings and feature toggles diffs#553
sarina merged 3 commits into
mainfrom
sarina/ulmo-teak-diff

Conversation

@sarina

@sarina sarina commented Nov 25, 2025

Copy link
Copy Markdown
Contributor

@sarina

sarina commented Dec 1, 2025

Copy link
Copy Markdown
Contributor Author

@feoh fyi. I generated this but I'm asking around to see if it's correct.

@sarina
sarina marked this pull request as draft December 1, 2025 16:55
@sarina

sarina commented Dec 3, 2025

Copy link
Copy Markdown
Contributor Author

I'm not confident I'll be able to generate this. I'm getting about 500 docs ERRORs in addition to another 600+ WARNINGs on the docs build.

@feanil

feanil commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@sarina can you try diffing these two files against the teak ones?
featuretoggles.xml
settings.xml

It has the setting that Kyle pointed out above. I generated it with parallel builds off, thinking that maybe something about the way the feature toggles tool works is not sufficiently threadsafe.

@sarina

sarina commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

Gotcha, thanks. The diff is different but the script output is the same, so I'll look to see if something is borked in my script.

@sarina
sarina force-pushed the sarina/ulmo-teak-diff branch from a68aca8 to cdda121 Compare December 5, 2025 17:33
@sarina

sarina commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

@sarina
sarina marked this pull request as ready for review December 5, 2025 17:37
@sarina

sarina commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

This mostly looks right but there are some settings in the settings diff that look like they may be annotated incorrectly?

+CORRECTLY_ANNOTATED_FLAG
'CORRECTLY_ANNOTATED_FLAG':True,

'NO_DOCUMENTATION_FLAG':False,

#..wrong_annotation
'WRONG_DOCUMENTATION_FLAG':False,
}

FEATURES={#pylint:disable=feature-toggle-needs-doc
'SECOND_NO_DOCUMENTATION_FLAG':False,
}: [.venv/lib/python3.11/site-packages/test/plugins/test_annotations_check.py (line 83)](https://github.com/openedx/edx-platform/blob/cf48323639bf24eed5ef120dfbd9e98cf0fd64af/.venv/lib/python3.11/site-packages/test/plugins/test_annotations_check.py#L83)
Default value = "Not defined"
Description: Desc: NaN
+MYTOGGLE
#..toggle_default:something: [.venv/lib/python3.11/site-packages/test/plugins/test_annotations_check.py (line 203)](https://github.com/openedx/edx-platform/blob/cf48323639bf24eed5ef120dfbd9e98cf0fd64af/.venv/lib/python3.11/site-packages/test/plugins/test_annotations_check.py#L203)
Default value = "Not defined"
Description: Desc: NaN
Description: MYTOGGLE [output truncated, see link for full description]
Description: Default: <literal>"Not defined"</literal>

there's quite a few like this

@sarina

sarina commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

Looks like those are all generated from test files, and we'll fix forward for Verawood.

@sarina
sarina merged commit 55267f7 into main Dec 10, 2025
2 checks passed
@sarina
sarina deleted the sarina/ulmo-teak-diff branch December 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants