Teak/Ulmo settings and feature toggles diffs - #553
Conversation
|
@feoh fyi. I generated this but I'm asking around to see if it's correct. |
|
I'm not confident I'll be able to generate this. I'm getting about 500 docs ERRORs in addition to another 600+ WARNINGs on the docs build. |
|
@sarina can you try diffing these two files against the teak ones? It has the setting that Kyle pointed out above. I generated it with parallel builds off, thinking that maybe something about the way the feature toggles tool works is not sufficiently threadsafe. |
|
Gotcha, thanks. The diff is different but the script output is the same, so I'll look to see if something is borked in my script. |
a68aca8 to
cdda121
Compare
|
Oh, yes. I wasn't properly generating the toggles/settings diff. Now it looks right. https://gist.github.com/sarina/de3069ef5bd59727d71a63ae556efdcb https://gist.github.com/sarina/d4200c7f63ab6ab30899a6168d6656a1 |
|
This mostly looks right but there are some settings in the settings diff that look like they may be annotated incorrectly? there's quite a few like this |
|
Looks like those are all generated from test files, and we'll fix forward for Verawood. |
https://gist.github.com/sarina/de3069ef5bd59727d71a63ae556efdcb
https://gist.github.com/sarina/d4200c7f63ab6ab30899a6168d6656a1