Skip to content

chore: upgrade Authoring MFE slot IDs to namespaced version - #1082

Merged
farhaanbukhsh merged 1 commit into
openedx:mainfrom
open-craft:tecoholic/update-authoring-mfe-plugin-slot-id
Jun 18, 2025
Merged

chore: upgrade Authoring MFE slot IDs to namespaced version#1082
farhaanbukhsh merged 1 commit into
openedx:mainfrom
open-craft:tecoholic/update-authoring-mfe-plugin-slot-id

Conversation

@tecoholic

Copy link
Copy Markdown
Contributor

Authoring MFE's slots were updated to use the namespaced ID format for all the slots in frontend-app-authoring PR#1854.

This commit brings the latest IDs to the Authoring MFE patch and also upgrades the unit-page sidebar slot to the latest version - v2.

Authoring MFE's slots were updated to use the namespaced ID
format for all the slots in frontend-app-authoring PR#1854.

This commit brings the latest IDs to the Authoring MFE patch
and also upgrades the unit-page sidebar slot to the latest
version - v2.
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @tecoholic!

This repository is currently maintained by @bmtcril.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 17, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 17, 2025
@tecoholic
tecoholic requested a review from farhaanbukhsh June 17, 2025 06:34
@farhaanbukhsh

Copy link
Copy Markdown
Member

@tecoholic do we need this change since we have idAliases?

@tecoholic

tecoholic commented Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh Yes and also the upgrade of unit page sidebar component to v2.

We fixed the sticky sidebar issue on the Unit Page Sidebar with V2 and that doesn't have an alias. It seemed better to update all the slot IDs, from alias to ID, along with it.

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on the tutor devstack
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation

@farhaanbukhsh
farhaanbukhsh merged commit 22acbe2 into openedx:main Jun 18, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 18, 2025
@bmtcril

bmtcril commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Does this need to be backported to Teak?

@tecoholic

tecoholic commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@bmtcril Yes, we need to make these available in Teak.

The corresponding backport to Authoring MFE has been merged -> openedx/frontend-app-authoring#2178

@farhaanbukhsh

farhaanbukhsh commented Jun 19, 2025

Copy link
Copy Markdown
Member

@tecoholic can you create a backport for this, please. Thanks

@bmtcril I see we don't have a release/teak branch here, do we need it?

@tecoholic

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh I looked around the branches and versioning of this repo. I don't understand it.

The README says,

The plugin is compatible with Tutor 15.0.0 and later and supports Open edX releases from Nutmeg onward.

and there aren't any open-release or release or tutor-xx branches.

Can you kindly give me some pointers of which branch should I use as a base for this backport?

@tecoholic

Copy link
Copy Markdown
Contributor Author

@farhaanbukhsh Pinging to check about this backport requirement.

@farhaanbukhsh

Copy link
Copy Markdown
Member

@tecoholic I think we don't need to backport .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants