chore: upgrade Authoring MFE slot IDs to namespaced version - #1082
Conversation
Authoring MFE's slots were updated to use the namespaced ID format for all the slots in frontend-app-authoring PR#1854. This commit brings the latest IDs to the Authoring MFE patch and also upgrades the unit-page sidebar slot to the latest version - v2.
|
Thanks for the pull request, @tecoholic! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@tecoholic do we need this change since we have idAliases? |
|
@farhaanbukhsh Yes and also the upgrade of unit page sidebar component to v2. We fixed the sticky sidebar issue on the Unit Page Sidebar with V2 and that doesn't have an alias. It seemed better to update all the slot IDs, from alias to ID, along with it. |
farhaanbukhsh
left a comment
There was a problem hiding this comment.
👍
- ✅ I tested this on the tutor devstack
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
|
Does this need to be backported to Teak? |
|
@bmtcril Yes, we need to make these available in Teak. The corresponding backport to Authoring MFE has been merged -> openedx/frontend-app-authoring#2178 |
|
@tecoholic can you create a backport for this, please. Thanks @bmtcril I see we don't have a release/teak branch here, do we need it? |
|
@farhaanbukhsh I looked around the branches and versioning of this repo. I don't understand it. The README says,
and there aren't any Can you kindly give me some pointers of which branch should I use as a base for this backport? |
|
@farhaanbukhsh Pinging to check about this backport requirement. |
|
@tecoholic I think we don't need to backport . |
Authoring MFE's slots were updated to use the namespaced ID format for all the slots in frontend-app-authoring PR#1854.
This commit brings the latest IDs to the Authoring MFE patch and also upgrades the unit-page sidebar slot to the latest version - v2.