[BD-46] fix: show skeleton while loading src in CardImageCap (hook) - #2846
Closed
khudym wants to merge 14 commits into
Closed
[BD-46] fix: show skeleton while loading src in CardImageCap (hook)#2846khudym wants to merge 14 commits into
khudym wants to merge 14 commits into
Conversation
|
Thanks for the pull request, @khudym! When this pull request is ready, tag your edX technical lead. |
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
10 tasks
fix: use ref for image
peterkulko
reviewed
Dec 5, 2023
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2846 +/- ##
===========================================
+ Coverage 0 92.83% +92.83%
===========================================
Files 0 238 +238
Lines 0 4272 +4272
Branches 0 1033 +1033
===========================================
+ Hits 0 3966 +3966
- Misses 0 302 +302
- Partials 0 4 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
Contributor
|
Closed according to #3992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
issue with the fact that the markup jumps when loading a picture.
The CardImageCap component will display the Skeleton if Contexts isLoading=true (but this applies to the data itself), if isLoading=false, the img tag with the received data will be rendered, and the actual loading of the image will begin.
Couple solutions:
Issue#2480
Deploy Preview
deploy-preview-2846
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist