Skip to content

feat: autosuggest error handling - #2652

Closed
cintnguyen wants to merge 1 commit into
openedx:masterfrom
cintnguyen:cindy/formAutosuggest-tab-behavior
Closed

feat: autosuggest error handling#2652
cintnguyen wants to merge 1 commit into
openedx:masterfrom
cintnguyen:cindy/formAutosuggest-tab-behavior

Conversation

@cintnguyen

Copy link
Copy Markdown
Contributor

Description

Added logic to set error handling when clicking or tabing outside of the component. Created logic to allow consumer to use freeform functionality. Created option values and seperate display versus data value logic.

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Added logic to set error handling when clicking or tabing outside of the component. Created logic to allow consumer to use
freeform functionality. Created option values and seperate display versus data value logic.
@netlify

netlify Bot commented Sep 22, 2023

Copy link
Copy Markdown

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2cc30d2
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/650e02da43c7d30008f0b0c2
😎 Deploy Preview https://deploy-preview-2652--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brian-smith-tcril

Copy link
Copy Markdown
Contributor

I'm going to close this now that #2899 is in, but it was absolutely helpful to reference when implementing that! Thanks so much for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants