Remove the edx.org comprehensive theme - #9955
Merged
Merged
Conversation
singingwolfboy
force-pushed
the
partially-revert-comprehensive-theming
branch
3 times, most recently
from
September 29, 2015 21:38
070ee8a to
8ab401d
Compare
Contributor
Author
|
@nedbat, can you review this PR? |
singingwolfboy
force-pushed
the
partially-revert-comprehensive-theming
branch
2 times, most recently
from
September 30, 2015 15:32
42eac99 to
c611903
Compare
Depends on functionality that has been temporarily reverted
singingwolfboy
force-pushed
the
partially-revert-comprehensive-theming
branch
from
September 30, 2015 15:33
c611903 to
7cd9db1
Compare
Contributor
|
As near as I can tell, this is a good reversion. 👍 |
singingwolfboy
added a commit
that referenced
this pull request
Sep 30, 2015
Remove the edx.org comprehensive theme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Competing PR with #9954. If we decide to revert comprehensive theming for the release, we should merge this PR or that one, not both.
There's a lot of useful things in PR #8271 that provide a framework
for the comprehensive theming system. If we need to remove the edx.org
theme from the codebase, we can leave most of PR #8271 in, to make it
easier to build on top of and get this feature back in.