i18n fix - #9868
Conversation
louyihua
commented
Sep 22, 2015
- Add missing '_()' in capa_base.py & video_xfields.py
- Fix a bug in instructor_dashboard.py that causes crash when ANALYTICS_DASHBOARD_NAME contains non-ascii characters.
- Workaround for mis-extractions inside .underscore files when using gettext along with interpolate.
|
Thanks for the pull request, @louyihua! I've created OSPR-823 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here. |
There was a problem hiding this comment.
We should change these two messages to use %(name)s format also.
367e9c1 to
c849bdb
Compare
|
@nedbat This is fixed. |
|
👍 |
|
@louyihua Thanks for this fix. Would you mind also updating our i18n guidelines in the docs repo to explicitly call out that we can't have gettext and interpolate on the same line? http://edx.readthedocs.org/projects/edx-developer-guide/en/latest/internationalization/i18n.html#underscore-template-files Feel free to tag @nedbat in that pull request ;) |
There was a problem hiding this comment.
Since you're here, can you please change this to use a better variable, eg %(start_date)s?
There was a problem hiding this comment.
@dsego gettext doesn't work in the same line as interpolate in underscore templates. Please be sure that you're properly testing your features for i18n. Further, please make sure to give formatting variables proper names when used in translator comments.
Variable name was broken by a commit in #9868. ECOM-2431