Skip to content

Implementing NYT's ICE track changes to Open Ended Assessements - #956

Merged
jbau merged 1 commit into
masterfrom
giulio/ice-pr
Sep 15, 2013
Merged

Implementing NYT's ICE track changes to Open Ended Assessements#956
jbau merged 1 commit into
masterfrom
giulio/ice-pr

Conversation

@caesar2164

Copy link
Copy Markdown
Contributor

@VikParuchuri, could you give this PR a look?

  • Added boolean to OE problem CMS settings to turn on ICE track changes
  • Added ICE init and tracking start/stop to HTML
  • Conditional in Peer Grading HTML for ICE container
  • CSS styling for ICE container and insertion/deletion elements
  • Added class to track changes HTML
  • Added ice.min.js as well as included it in the js requirements for peer grading
  • Use track_changes in peer_grading_problem
  • (@jrbl) Refactor peer_grading_problem to lookup track_changes variable by problem location.
  • (@jrbl) Whitelist ICE insert, delete tags
  • (@jrbl) Adds ICE multi-user-editor insert and delete tags to the peer grading sanitize_html whitelist.
  • add reset button

@ghost ghost assigned VikParuchuri Sep 13, 2013

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the boolean to CMS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want any "Caution: this is experimental!" caveats?

@VikParuchuri

Copy link
Copy Markdown
Contributor

High level: I really like this idea, and it could be a significant value add.

@VikParuchuri

Copy link
Copy Markdown
Contributor

How is this displayed to students in the combinedopenended module? Do we need any css to style it properly?

Never mind, I see the css. Do you have any screenshots so we can know if we need to change any HTML around?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this just be included in peer_grading_problem.js as a function and conditionally called? This does not really tie in with our javascript workflow.

You could also just bundle it into a file and have the peer grading xmodule load it.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New .coffee file for what used to be in the <script> tag in peer_grading_problem.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants