Fix linking problem for peer grading, add in a test - #955
Conversation
There was a problem hiding this comment.
What should happen if more than one linked_descriptors is present? Seems like it ought to check....
There was a problem hiding this comment.
And what would the behavior for use_for_single_location be if there are multiple locations listed?
There was a problem hiding this comment.
The code in the descriptor ensures that there will only be one linked descriptor, as does the way the XML, etc, is laid out. a problem can only be linked to one location.
There would never be multiple locations to deal with.
|
I'm okay from an emergency standpoint. But if you go back into the code, there are several PEP8 issues in peer_grading_module.py that can be cleaned up (along with comments). It would be good to start cleanup as we go forward. And I see now that the descriptor returns a list of length 1 or 0 for get_required_module_descriptors, so if you are making an assumption about this, you should add a comment in the code to reflect that assumption. (If I ask the question, then I figure someone else is likely to, so it should be commented.) |
|
Closing in favor of https://github.com/edx/edx-platform/pull/971 . |
Add support for subtitle download link
2 participants
Fix peer linking issue identified in https://edx-wiki.atlassian.net/browse/OEE-136 . @brianhw Please review.