Skip to content

Add ARIA dialog role to Markdown editor dialogs - #950

Merged
gwprice merged 1 commit into
masterfrom
gprice/dialog-role
Sep 13, 2013
Merged

Add ARIA dialog role to Markdown editor dialogs#950
gwprice merged 1 commit into
masterfrom
gprice/dialog-role

Conversation

@gwprice

@gwprice gwprice commented Sep 12, 2013

Copy link
Copy Markdown

I verified that the role is properly inserted into both the Insert Hyperlink and Insert Image dialogs and that ChromeVox responds appropriately.

@marcotuts @kevinchugh @jimabramson

@marcotuts

Copy link
Copy Markdown
Contributor

this looks great. thumbs up for me. 👍

@marcotuts

Copy link
Copy Markdown
Contributor

One additional note - we have a couple places in capa where we create div elements directly via javascript for the purposes of iframes. Here are most of them:

Should this be added to a backlog for a fix similar to this one? (In the meantime I've presumed yes and added to JIRA LMS)

/Users/marco/mitx_all/edx-platform/common/static/js/capa/jsme/hosted.html:
24: var iframeDiv = topDoc.createElement("div");
173: var outer = topDoc.createElement("div");

/Users/marco/mitx_all/edx-platform/common/static/js/capa/jsmolcalc/hosted.html:
24: var iframeDiv = topDoc.createElement("div");
173: var outer = topDoc.createElement("div");

/Users/marco/mitx_all/edx-platform/common/static/js/capa/protex/hosted.html:
24: var iframeDiv = topDoc.createElement("div");
173: var outer = topDoc.createElement("div");

@jimabramson

Copy link
Copy Markdown

👍

gwprice pushed a commit that referenced this pull request Sep 13, 2013
Add ARIA dialog role to Markdown editor dialogs
@gwprice
gwprice merged commit e360f1d into master Sep 13, 2013
@gwprice
gwprice deleted the gprice/dialog-role branch September 13, 2013 17:43
pomegranited pushed a commit to open-craft/openedx-platform that referenced this pull request Nov 3, 2017
bumped gradebook and api-integration versions
kluo pushed a commit to kluo/edx-platform that referenced this pull request Oct 19, 2019
* Commits:
  Fix branding_stanford home page tiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants