Add link in lms legacy instructor dashboard to cms course_index - #859
Conversation
A one-click way of getting to editing the course
|
I'm concerned that this is not the right approach for us because of the way the Drupal site handles URLs (it's not as simple as what is done on Edge). I've asked someone on the Studio team to take a look. This introduces some pep8 and pylint violations - please address those. |
There was a problem hiding this comment.
Do we need the host or can it be a relative url? Can you get the url via Location().url() v this construction?
There was a problem hiding this comment.
It does need the host because it's used for an external link (for the LMS to link to CMS). It's similar in spirit, (but in opposite direction) as https://github.com/edx/edx-platform/blob/master/cms/djangoapps/contentstore/utils.py#L92
There was a problem hiding this comment.
and sure, I can switch to a better utility function.
There was a problem hiding this comment.
@dmitchell actually, having looked at Location().url(), I don't think that's actually the right thing, mainly because the addressing scheme of the URL it returns is internal rather than a standard external url. eg:
In [8]: Location(loc_or_tag="internal", org="org", course="course", category="cat", name="name").url()
Out[8]: 'internal://org/course/cat/name'
I'd have to parse out the "protocol" part of that URL anyway to make it into an actual working URL for 'course_index' in CMS (which doesn't take location as is), so I'm thinking that not much is gained by existing library functions here. But maybe I'm missing some extra support for "course" modules like they exist for "static" ones?
Basically, what I really wanted to do was a django.core.urlresolvers.reverse, but couldn't because it was across different applications and settings files
|
I'm not sure I'm loving the placement of the link. Would it be possible to put it underneath the "Try New Beta Dashboard" link? |
|
Somehow I manage to fix, then break, the email thing for XML backed courses. Since you define the new |
|
Thanks! Will address the other comments in short order. Sorry 'bout the PEP8 / Pylint sloppiness. Jason On Sep 4, 2013, at 8:33 AM, Sarina Canelake notifications@github.com wrote:
|
* Uses override_settings to provide test variable * Move location of cms link to upper right * PEP8 / Pylink
|
ok I repushed changes for the test and where the link appears @sarina @singingwolfboy |
|
👍 |
|
@dmitchell gave his blessing via hipchat. |
Add link in lms legacy instructor dashboard to cms course_index
houston student verification
…oning Update version of Platform Tour to 1.0.2
4 participants
A one-click way of getting to editing the course from the LMS instructor panel.
@sarina do you mind doing giving me comments on PR (or point me towards others)? The test coverage, etc is all there.
Basically, we've had faculty request an easier way of getting to edit course content from the instructor panel in LMS. I think there's more specific links for editing (in github) if the content is xml-backed, but linking to the CMS course_index would be enough to satisfy our faculty.
I realize it uses the legacy dashboard, but maybe that makes the merge considerations less stringent? =)