Make edxmako cache properly with changing lookup paths - #8552
Merged
Conversation
Contributor
Author
|
BTW, the larger theming work: https://github.com/edx/edx-platform/pull/8271 |
Contributor
|
👍 |
nedbat
added a commit
that referenced
this pull request
Jul 1, 2015
Make edxmako cache properly with changing lookup paths
Contributor
|
@nedbat sorry, I didn’t see this in all those new notifications I suddenly received! This is good. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For theming (in a separate, larger branch), we need to be able to change the lookup directories dynamically (for testing now, for multi-tenancy later). When that happens, the mapping from uri ("footer.html") to actual file can change, which is the whole point of changing the lookup directories.
To make it work properly, we have to cache the files in a different directory for different lookup paths, and clear the internal caches so that the files will be examined again.
@cpennington @tusbar opinions?