Cleanup bulk email app - #855
Merged
Merged
Conversation
Contributor
|
Oops. |
Contributor
There was a problem hiding this comment.
Issue with this test is that the arguments to delegate_email_batches has changed. It expects a CourseEmail object to be created. And there should presumably be a factory for creating one.
Contributor
Author
There was a problem hiding this comment.
So, that's why I just deleted this test - it was passing but for the wrong reasons. This test was written when we had more arguments to the function, most of which we removed.
This exact area of code is tested elsewhere - tests/test_err_handling, test test_nonexist_course
Contributor
|
I see -- looks good then. |
Contributor
|
👍 |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
tweaked collapsible selector to target the proper section
cgopalan
referenced
this pull request
in open-craft/openedx-platform
Aug 24, 2017
YONK-742: User update API allowed to set country,city & gender as NULL
caesar2164
added a commit
to caesar2164/edx-platform
that referenced
this pull request
Dec 18, 2018
Add Platform Tour xBlock to requirements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly pep8/pylint fixes.
Brian - I got rid of one test in
test_email.pybecause it wasn't working right, and is already tested intest_err_handling. I also added a close connection in tasks because looking through I don't think we should leave on that except clause without closing it.@brianhw @adampalay