Skip to content

fix pep8 and pylint errors - #853

Merged
adampalay merged 1 commit into
masterfrom
fix/adam/pylint-pep8
Sep 3, 2013
Merged

fix pep8 and pylint errors#853
adampalay merged 1 commit into
masterfrom
fix/adam/pylint-pep8

Conversation

@adampalay

Copy link
Copy Markdown
Contributor

@sarina @wedaly

Fixes a bunch of pep8 and pylint violations. The hotfix will add some violations to master; this PR is meant to help offset that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird spacing. Prefer

location = [
    'i4x',
    ...,
    None
]

@sarina

sarina commented Sep 3, 2013

Copy link
Copy Markdown
Contributor

👍 once comments addressed

@adampalay

Copy link
Copy Markdown
Contributor Author

Thanks, will change and squash

Conflicts:
	cms/djangoapps/contentstore/views/course.py
	common/lib/xmodule/xmodule/tests/test_combined_open_ended.py
	lms/envs/common.py
@wedaly

wedaly commented Sep 3, 2013

Copy link
Copy Markdown
Contributor

👍

adampalay added a commit that referenced this pull request Sep 3, 2013
@adampalay
adampalay merged commit ef042c3 into master Sep 3, 2013
@adampalay
adampalay deleted the fix/adam/pylint-pep8 branch September 3, 2013 21:22
cgopalan referenced this pull request in open-craft/openedx-platform Aug 29, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API
* added tests for html xblock student_view_data
ny0m referenced this pull request in open-craft/openedx-platform Aug 31, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API
* added tests for html xblock student_view_data
ziafazal pushed a commit that referenced this pull request Dec 12, 2017
* added student_view_data to HtmlBlock to allow html to be downloadable via the course blocks API
* added tests for html xblock student_view_data
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Aug 3, 2018
caesar2164 pushed a commit to caesar2164/edx-platform that referenced this pull request Dec 15, 2018
* stv/unfork/cms/comment:
  Remove useless comment fork
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants