Fix capa optioninput template to honor inline flag - #845
Merged
chrisndodge merged 2 commits intoSep 5, 2013
Conversation
Contributor
|
Hi Ike, Looking at the code, I see - though not your original code - that in Optioninput 'inline' defaults to an empty string, whereas in other uses (TextLine) it defaults to False. I think it'd be better if optioninput treats inline as a boolean rather than a string, in the same manner as textline. do you want to do that (also need to update a test [test_inputtypes.py] which asserts an empty string)? Thx. |
Contributor
Author
|
Done |
chrisndodge
pushed a commit
that referenced
this pull request
Sep 5, 2013
…for-inline Fix capa optioninput template to honor inline flag
cgopalan
referenced
this pull request
in open-craft/openedx-platform
Aug 20, 2017
YONK-738: Course Blocks API updates
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jul 27, 2018
Update rocketChat
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Dec 11, 2018
Fix eslint errors in account settings js
Abdul-Muqadim-Arbisoft
pushed a commit
to edly-io/edx-platform
that referenced
this pull request
May 8, 2024
It was observed that waiting time was cut in half after http/3 was enabled. Plus, supporting http/3 is super easy :) Close openedx#845
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "inline" flag is used to allow capa input elements to be displayed inline. This is useful, for example, when questions are written as paragraph text, with inputs embedded within the text.
The
textlineinput element honors the inline flag -- see https://github.com/edx/edx-platform/blob/master/common/lib/capa/capa/templates/textline.html#L1This PR fixes the
optioninputtemplate to also honor the inline flag (note that https://github.com/edx/edx-platform/blob/master/common/lib/capa/capa/inputtypes.py#L328 already provides the inline flag in the mako context).