Skip to content

Jbau/bulk email faster tests - #841

Merged
jbau merged 2 commits into
masterfrom
jbau/bulk-email-faster-tests
Aug 30, 2013
Merged

Jbau/bulk email faster tests#841
jbau merged 2 commits into
masterfrom
jbau/bulk-email-faster-tests

Conversation

@jbau

@jbau jbau commented Aug 30, 2013

Copy link
Copy Markdown

@nedbat @sarina

I've made a mockery of test_err_handling.py. Can you see if it's faster now? I didn't change the semantics of the tests much, so coverage should remain the same.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any day i get to learn a new itertools fn is a Good Day. 🐣

@sarina

sarina commented Aug 30, 2013

Copy link
Copy Markdown
Contributor

Looks 🙆‍♀️ to me

👍

@nedbat

nedbat commented Aug 30, 2013

Copy link
Copy Markdown
Contributor

7 seconds to run the tests. Much better. 👍

@jbau

jbau commented Aug 30, 2013

Copy link
Copy Markdown
Author

cool.

jbau added a commit that referenced this pull request Aug 30, 2013
@jbau
jbau merged commit b7e8af6 into master Aug 30, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Victor/capa cleanup

Looks good.  Yes, the code exec part will need more thought, particularly with respect to security.
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Jul 25, 2018
kluo pushed a commit to kluo/edx-platform that referenced this pull request Nov 30, 2018
Efficiency improvement for EnrollmentRosterView.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants