Skip to content

Skip migrations if running acceptance in fasttest mode - #837

Merged
wedaly merged 1 commit into
masterfrom
will/faster-acceptance-test-startup
Sep 3, 2013
Merged

Skip migrations if running acceptance in fasttest mode#837
wedaly merged 1 commit into
masterfrom
will/faster-acceptance-test-startup

Conversation

@wedaly

@wedaly wedaly commented Aug 30, 2013

Copy link
Copy Markdown
Contributor

If running rake fasttest_acceptance_* and the acceptance test database already exists, flush it instead of doing a syncdb/migrate.

Running without fasttest works the same as it always has.

This makes it much faster to test/debug individual scenarios.

Reviewer: @jzoldak

Comment thread rakelib/tests.rake Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this here because in browser.py before each scenario we do call_command('flush', interactive=False)

@wedaly

wedaly commented Sep 2, 2013

Copy link
Copy Markdown
Contributor Author

@jzoldak Good call -- I removed acceptance_static.py and the database flush commands.

@JonahStanley

Copy link
Copy Markdown
Contributor

Glad to see that we can remove migrations in this case. The point of acceptance_static was to prevent the creation of a randomized mongo collection/database. If no randomization is needed then the seed reference there should also be removed otherwise there will be leftover collections/databases from running the test_acceptance command.

At least that is what I remember from making it. If all of the mongo databases are cleared at the end of any test_acceptance run then everything should be good

@wedaly

wedaly commented Sep 2, 2013

Copy link
Copy Markdown
Contributor Author

@JonahStanley Thanks for clarifying. I just checked, and it looks like the acceptance tests are dropping the databases and collections that get created, even though these names are randomized.

@jzoldak

jzoldak commented Sep 3, 2013

Copy link
Copy Markdown
Contributor

hey @JonahStanley! IIRC it was the django test dbs created by the gather asset rake task that were being left behind. Since those aren't seeded now in acceptance.py they won't be left behind.

👍

wedaly pushed a commit that referenced this pull request Sep 3, 2013
Skip migrations if running acceptance in fasttest mode
@wedaly
wedaly merged commit e284ac6 into master Sep 3, 2013
@wedaly
wedaly deleted the will/faster-acceptance-test-startup branch September 3, 2013 18:58
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…os-x-10.8

Set git push.default to current on the create-dev-env script
ny0m referenced this pull request in open-craft/openedx-platform Aug 14, 2017
MCKIN-5350: XBlock Image Explorer version update
jfavellar90 pushed a commit to eduNEXT/edx-platform that referenced this pull request Aug 23, 2018
ENH: setting to remove platform name from registration page
kluo pushed a commit to kluo/edx-platform that referenced this pull request Nov 30, 2018
…_reports

Fix problems with grade reports after removing anonymous|lti
DanielVZ96 referenced this pull request in open-craft/openedx-platform Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants