Skip to content

Instrument course email for DataDog - #831

Merged
wedaly merged 1 commit into
masterfrom
will/statsd-bulk-email
Aug 30, 2013
Merged

Instrument course email for DataDog#831
wedaly merged 1 commit into
masterfrom
will/statsd-bulk-email

Conversation

@wedaly

@wedaly wedaly commented Aug 29, 2013

Copy link
Copy Markdown
Contributor

Reviewer: @sarina

@sarina

sarina commented Aug 30, 2013

Copy link
Copy Markdown
Contributor

This looks right to me.

I'm trying to think - was there anything else we wanted to measure?

I think there's probably a couple other things we might want to know when this is live for courses (I'm thinking particularly, how many unique courses are sending mail, and maybe what the option that they're using is).

Talking with Miki I do plan to try to do some testing with 2-3 courses sending mail simultaneously, so being able to somehow distinguish or know about multiple courses performing mail simultaneously might be a good idea.

Comment thread lms/djangoapps/bulk_email/tasks.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fyi it's not strictly necessary to run this check. In Python,

tag[:INDEX]

will slice the string from index 0 up to but not including INDEX, even if the string is shorter:

>>> tag = 'hello'
>>> tag[:200]
'hello'

@wedaly

wedaly commented Aug 30, 2013

Copy link
Copy Markdown
Contributor Author

I learn something new everyday :) Updated to use slices to enforce string length limit.

@sarina

sarina commented Aug 30, 2013

Copy link
Copy Markdown
Contributor

👍

wedaly pushed a commit that referenced this pull request Aug 30, 2013
Instrument course email for DataDog
@wedaly
wedaly merged commit f15f4fd into master Aug 30, 2013
@wedaly
wedaly deleted the will/statsd-bulk-email branch August 30, 2013 17:15
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…tyle

move output right/wrong image to top left of each test instead of center
pomegranited referenced this pull request in open-craft/openedx-platform Aug 7, 2017
YONK-15: API optimisations using course blocks (FIX)
jfavellar90 added a commit to eduNEXT/edx-platform that referenced this pull request Aug 23, 2018
kluo pushed a commit to kluo/edx-platform that referenced this pull request Oct 31, 2018
…nauth_from_reports

Exclude unauthenticated and lti users from the grade reports and instructor dash.
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
…penedx#831)

We need to allow both Timed exams and non-exam types content to be rendered

Co-authored-by: Simon Chen <schen@edX-C02FW0GUML85.local>
DanielVZ96 referenced this pull request in open-craft/openedx-platform Jan 31, 2024
* docs: Directions to enable metric collection

This is added to getting started section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants