fix: make edit link use static_asset_path in xmodule_modifiers.py - #814
Conversation
|
Hi Ike, thanks for the contribution. I'm not clear on the github edit workflow - plus I'm out this week to spend time to learn this. So even though this looks like a trivial change, I'm wondering if someone else could take a quick look. @ormsbee sorry to tag you again, but you might have a good sense of this one line change.... |
…ang/make-edit-link-use-static-asset-path Conflicts: common/djangoapps/xmodule_modifiers.py
|
updated. This is a one-line change... |
|
Thx. I'll give this a spin tomorrow. |
|
@cpennington is 'module.lms.static_asset_path' still valid? We got rid of those namespaces right? |
|
Yeah, should just be |
|
hmm. Actually, |
|
Hmmm. Build is reported as failing. I'm having trouble connecting to Jenkins from home. I'll check what the failure is tomorrow. |
…ang/make-edit-link-use-static-asset-path
|
probably because of all the recent changes, eg video captions tests. rebased. |
|
@ichuang OK build is passing after rebase. Ike, can you manually verify the change? It'll take me while to get a manual test pass that exercises the block.static_asset_path change. Thx. |
|
👍 |
…atic-asset-path fix: make edit link use static_asset_path in xmodule_modifiers.py
…ration_phase3 Add specific aggregation function for ga_operation tools openedx#617
Update xblock-chat to latest version.
…olled_students_report Restricted enrolled students reports GDPR
* sm/fix-activation-link: Add port to activation link to keep it from failing on devstack.
4 participants
The "edit" link in the LMS is used by course authors working with the "github+mongoLMS" workflow. This edit link is meant to go to the specific github page where the source XML is stored.
In the old setup where XML files were loaded from a data directory, the edit link was constructed using the path for that directory.
In the new setup, the proper directory to use is determined by
module.lms.static_asset_path.This PR fixes the edit link to use the proper directory path.
[ A future addition would be to make the edit link go to Studio, for courses using the Studio workflow ]