Add delete confirmation to static pages. - #787
Merged
Merged
Conversation
We used to use a regular JS `confirm`; this makes the UI consistent with the rest of Studio.
|
👍 |
peter-fogg
pushed a commit
that referenced
this pull request
Aug 23, 2013
Add delete confirmation to static pages.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
May 9, 2016
…invitation Fix bug of ContractRegister. openedx#786 Fix bug of access to Course About and Course Info. openedx#788
andrey-canon
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Jun 21, 2018
Staff can add an user to a team
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
ref ARCHBOM-1806
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking into the static pages I noticed that we were still using a JS
confirmon deletion; this makes the UI consistent with the rest of Studio.@singingwolfboy @talbs