Drupal side Register button updates - #713
Merged
Merged
Conversation
…ond line of text - and IE-specific styling
Contributor
There was a problem hiding this comment.
Any particular reason we're using lowercase? (Isn't the ISO standard uppercase?) And are we saying that the right way to denote free is 0 + "usd"?
Do we need a unique constraint on (course_id, mode, currency)?
Contributor
Author
There was a problem hiding this comment.
I used lowercase because that's what was being used in the existing payment/order infrastructure. I suspect this is because Cybersource uses the lower case codes.
I do think a uniqueness constraint there makes sense. I'll put it in.
Contributor
|
👍 |
Contributor
|
@dianakhuang and @frrrances, this looks good to me. I just made a few quick tweaks to the Sass/rendered CSS to use the $white variable and to match our opacity standards (so we can keep up hope of cleaning this someday :P). Your previous work looks solid, thx! - 👍 |
dianakhuang
added a commit
that referenced
this pull request
Aug 19, 2013
Drupal side Register button updates
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Don't use the search API to retrieve all threads.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
May 20, 2016
…ration_p2 Add aggregate function for ga_operation tools openedx#617
e-kolpakov
referenced
this pull request
in open-craft/openedx-platform
Jun 22, 2016
bump grade book app version
caesar2164
added a commit
to caesar2164/edx-platform
that referenced
this pull request
Oct 31, 2017
…rt-button Migrates shopping cart button css to forum
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 20, 2018
Proversity/staging
morenol
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Aug 27, 2019
) Fix user creation process in the sysadmin dashboard. Cherry-pick from the commit 4e1a937 by a-kryachko
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
…dx#713) Co-authored-by: Renovate Bot <bot@renovateapp.com>
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
* feat: add "Edit on Github" button in breadcrumbs Currently, viewers of documentation would need to know alot about a page to know where they need to go to fix outdated docs. "Edit on Github" button should decrease the barrier in entry for improving docs. * chore: running upgrade to get new edx-spinx-theme
AhtishamShahid
pushed a commit
that referenced
this pull request
Mar 4, 2026
* feat: Validate country input during student registration Added validation to ensure that the country code provided during student registration is valid. If the country code is invalid, an error message is appended to the row errors for appropriate feedback. * feat: Trigger event on student registration completion - Added functionality to send a STUDENT_REGISTRATION_COMPLETED event upon successful user creation - This signal is used to create EdlyMultiSiteAccess objects that give tenant access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ormsbee @talbs