Zoldak/hotfix fix captions sync - #708
Closed
jzoldak wants to merge 2 commits into
Closed
Conversation
…yback. Because with speed changing the time also changes for Flash playback, a different way to calculate the current time is needed than for HTML5 playback. I have added conditions for Flash and HTML5 video, and put old method of calculating time for Flash. I have tested it on the YouTube video ZwkTiUPN0mg. Both HTML5 mode and Flash mode have proper video-captions syncing with this fix. NOTE: to view YouTube video in Flash mode you either have to use an old browser (ex. Firefox version 18) or hard code in source that state.currentPlayerMode = 'flash' (in function _setPlayerMode(), file 01_initialize.js).
Contributor
Author
|
closing in favor of a hotfix branch that has all 3 hotfixes needed for today's deployment. |
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Feature/cale/cms bug fixes
e-kolpakov
referenced
this pull request
in open-craft/openedx-platform
Jun 22, 2016
MCKIN-4174 Group Work v2: hash update
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Oct 27, 2017
* ggg/merge-register-theme: Removes deprecated setting Makes register page use themed optional extra tpl
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 20, 2018
revert deployment testing commit
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
…nds (#708) - Pause and warn when pull/provision/up/check are run without a service specified - Introduce a `*.default` variation for when using the default set is intentional We've seen that a lot of developers use `dev.pull` and `dev.up` and then experience the resulting pain around bandwidth and memory. This is an experiment in education -- rather than responding in chat when someone asks where all the RAM has gone, can we guide people away from these commands in a tighter loop? (Implementation note: Keeping the main text out of the cowsay allows us to have variable length text (interpolate the make target) without messing up the speech bubble borders or having to install the cowsay package.)
DanielVZ96
referenced
this pull request
in open-craft/openedx-platform
Jan 31, 2024
…nds (#718) - Pause and warn when `dev.pull` and `dev.up` are run without a service specified - Introduce a `*.large-and-slow` variation for when using the default large set is intentional We've seen that a lot of developers use `dev.pull` and `dev.up` and then experience the resulting pain around bandwidth and memory. This is an experiment in education -- rather than responding in chat when someone asks where all the RAM has gone, can we guide people away from these commands in a tighter loop? (Previously merged as commit 80ed748/PR #708; this contains some improvements on that.) See ADR for additional information. Implementation notes: - Keeping the main text out of the cowsay allows us to have variable length text (interpolate the make target) without messing up the speech bubble borders or having to install the cowsay package. - If a Makefile has `dev.X.default: dev.X.$(DEFAULT_SERVICES)` with no statements followed by `dev.X.%: ...` then make would end up running `dev.X.%` for *both* the DEFAULT_SERVICES and `default`, and the latter would error out. The fix here is just to ensure that there is at least one statement, even if it does nothing. (Using a different pattern such as `default_dev.X` would also have worked but been confusing, and this solution is conducive to a small explanatory comment.) Changes from previous PR: - Makefile bugfix as mentioned above. - Just include `pull` and `up` for now; `provision` and `check`, are good candidates for after this is proved out. (`migrate` and `reset` can be included later as well.) - Remove "deprecated" comment from old default targets. We are not actually deprecating them at this point, just warning people about inadvertent use of them. - Use name `large-and-slow` instead of `default`; the contents of `DEFAULT_SERVICES` shouldn't *be* the default, and are really more of an 80%-case that covers most people's workflows (but includes too much.) Rename warning script accordingly. - Update README section "Service List" with better instructions and give a pointer from the setup instructions, including some service combinations. - Update other doc and Makefile locations to reference either the "big hammer" or the "small hammer" as appropriate to the context. - Don't print directory "changes" on this recursive make. - Use `lms` as example service in the warning message, since it's a common case. - Specify how to cancel the command (same key combo works on both Mac and Linux). - Add ADR.
AhtishamShahid
pushed a commit
that referenced
this pull request
Mar 4, 2026
* fix: Don't show non-active programs #317 * feat: Enhance program caching by filtering active tenants and using tenant-specific catalog API URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.