video_module: Add deserialize logic for metadata fields. - #679
Conversation
|
@peter-fogg @vaxXxa Please review. |
|
Looks good; 👍 when tests pass. |
STUD-640 Handle the case of the double-quotes appearing within the string. We don't need to worry about the whole concatenated ID being double-quoted, since the concatenation was done by overriding xml_module's export method. Use the method already fined in XmlDescriptor.
|
I modified the solution to make use of the existing deserialize method in XmlDescriptor. |
|
👍 New code also looks good. |
|
@cahrens, if I correct understand, in the future we will delete block of code, where we manage quoted strings, right? Cause, |
|
@vaxXxa No, I don't expect we will remove this code in the future. We could possibly remove the code on L299 once we are confident that all our courses do not have the double-quoting within the concatenation (that could only have been created on export during a small time frame, since we stopped double-quoting strings), but I don't think we should remove line 357. We have continued using json.dumps for exporting all non-String types, so it is possible to hit issues with other fields as well. Peter wrote a custom xml_exporter for videoalpha (currently in master as video). So export right now goes through video_alpha's custom implementation. But with @chrisndodge ' PR (https://github.com/edx/edx-platform/pull/688), videoalpha will go back to using XmlDescriptor's serialization mechanism, which means we should deserialize in a consistent way. |
|
@vaxXxa You are correct that I can stick with the classmethod instead of staticmethod. I have made that change and pushed up. I am now going to take these changes and put them on Chris' branch so we can release this stuff together. |
|
This change got pulled into Chris' PR. |
Feature/bridger/wiki fixes
…x-secret-course-info Fix course_info to secret openedx#678
Update problem builder hash.
…anslation-fix UPD: removing translating of studio options, not needed, and breaks e…
…s-entr Revert "Patches"
…openedx#679) Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Update mongo3.6 to 4 on devstack * Added script to upgrade mongo to 4
3 participants
STUD-640