Valera/bugfix tabbing video controls - #659
Conversation
|
@valera-rozuvan, this looks good in general. I do have one question: I noticed that once the speed menu is opened, I am able to tab through all of the speeds (which is great), but if I want to reverse tab back through the previous speeds (going frmo 0.25 to 2.o for example), I'm not able to (as I get jumped to toggling the speed menu in general again). Can you address this? |
|
@talbs The cause of this is that we can't tell the direction of tabbing. We have the 'focus' and 'blur' events. Unfortunately, different means of focus switching use different mechanisms (keyboard, screen readers, etc.) - so we can't just assume that all backward tabbing will be done with a Shift+Tab. This is why I have to always assume that when the user is on the last speed (the one on the bottom, 0.25), he is tabbing forwards. You can go backwards (focus) from a speed one higher than 0.25 - please try this. Maybe you can suggest a solution to this problem. I have thought about hard coding the order of controls, and then looking on each 'blur' and 'focus' events where we are coming from. The only problem with this approach is that when a new control is added, hard-coding will have to be redone. |
ghost
assigned
|
@valera-rozuvan, thanks for the explanation. I don't think this is a blocker for this work being merged in and I don't have time currently to dive in. The feature is definitely usable without it, I'd just note the extra tab work somewhere in the backlog (where it can be prioritized). 👍 from me. |
|
Were these bugs present in the old video player? Or is it a new issue in Videoalpha? Either way, looks good. 👍 when the tests pass. |
|
@peter-fogg These bugs were not present in old video player because this is new functionality. Tabbing through controls forwards and backwards has been added only recently. |
An old TODO item was done. It turns out a simple case of calling the method to bind handlers after the Spees dialog was re-rendered.
Now you can tab through all of the controls in Video forwards, and then tab backwards.
|
@valera-rozuvan After addressing my comments, you can merge. 👍 |
Valera/bugfix tabbing video controls
Remove widows in accordion header
Hash update: Problem Builder
…z-for-merge-dashboard-link Implements biz dashboard link openedx#606
* stv/style-guide: Explain commented code in style guide Explain trailing commas in style guide Explain collection definition in style guide Explain import sorting in style guide Explain docstrings in style guide
feat: backport HomepageRenderStarted and CatalogRenderStarted filters
4 participants
This PR provides fixes for bugs:
1.) When tabbing backwards, focus should switch in succession ( https://edx-wiki.atlassian.net/browse/BLD-228 ).
2.) Tabbing from speeds to volume control doesn't close Speeds dialog ( https://edx-wiki.atlassian.net/browse/BLD-233 ).
Reviewers