refactor tab modification by components - #6549
Conversation
1ea8833 to
3a3cde0
Compare
There was a problem hiding this comment.
I'd prefer to name it so is_advanced_module_present.
There was a problem hiding this comment.
Looks like _a_component_is_present and _component_value_true get the same arguments, but argument's names differ. I'd like to see the same names in both function. For example, components.
There was a problem hiding this comment.
let's settle on is_advanced_component_present - they are called components all over
734ddeb to
b157949
Compare
There was a problem hiding this comment.
I'd prefer to name it so is_field_value_true or is_truthy.
There was a problem hiding this comment.
Do we really need to pass the request as an argument or we can pass request.json instead?
There was a problem hiding this comment.
is_field_value_true it is
|
👍 once tests pass and small comments will be addressed. |
8a04711 to
56a75b5
Compare
56a75b5 to
c384ee5
Compare
refactor tab modification by components
@polesye please take a look