Prevent Jasmine tests from redirecting in dev mode - #6546
Merged
Conversation
Also prevent Jasmine from attempting to load deleted templates
Contributor
|
👍 |
Contributor
|
👍 Thanks for addressing this so quickly, @rlucioni. |
rlucioni
pushed a commit
that referenced
this pull request
Jan 11, 2015
Prevent Jasmine tests from redirecting in dev mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also prevents Jasmine from attempting to load deleted templates.
@andy-armstrong this should fix the redirection issues you noticed on Friday and filed as ECOM-885. It doesn't completely clean out the console errors we saw, but it does remove several.
@wedaly or @AlasdairSwan, could one of you also review this? Andy was having issues with the Jasmine tests appearing to redirect while running in dev mode; this was caused by
history.pushStatenot being mocked out.EDIT: An instructor dashboard test related to coupons, added on Friday by @muhhshoaib, is still failing.