Fix for ECOM-876 - #6483
Merged
Merged
Conversation
Contributor
|
Looks good 👍 |
Contributor
|
Looks great! I'm not sure if this matters, but you may want to consider changing |
Contributor
Author
|
Will merge as soon as tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECOM-876: TypeError in payment JavaScript
The error would occur for course modes with exactly one suggested price. Since
data()returns a number in this case, not a string, thesplit()function raised a type error.We don't have existing tests that cover this, so in the interest of unblocking the release, I'd like to merge this into the RC and wait until we implement Selenium tests (next sprint) to cover this case.
I manually tested the payment flow with a course mode that had 0, 1, and 2 suggested prices.
@AlasdairSwan please review
FYI: @dsjen @cdodge