Ziafazal/collect user milestones - #6480
Closed
ziafazal wants to merge 3 commits into
Closed
Conversation
added edx-milestones repo split milestones and pre-requisite course flags added a unit test in lmd and fixed broken tests removed extra line updates to use milestone app api instead of signals fixed broken test making pre-requisite ddl property of settings page user dashboard messaging changes after marco's feedback removed text-truncated from mixing and fixed broken test removed pre-requisite gating logic added lms boo choy test UX changes after merge with master fixed broken unit test wait for course section to loaded fixed broken boo choy test changes after feedback fixed broken unit test
added edx-milestones repo split milestones and pre-requisite course flags added a unit test in lmd and fixed broken tests removed extra line updates to use milestone app api instead of signals fixed broken test making pre-requisite ddl property of settings page user dashboard messaging changes after marco's feedback removed text-truncated from mixing and fixed broken test removed pre-requisite gating logic added lms boo choy test UX changes after merge with master fixed broken unit test wait for course section to loaded fixed broken boo choy test bok-choy studio test for pre requisite course deleted the signals.py and improve code quality. Updated message text changes based on feedback
Contributor
|
Overall looks good. I'd suggest merging this into the main feature branch once you clean up the code quality violations: 16:39:33 lms/djangoapps/certificates/tests/tests.py (92.3%): |
added edx-milestones repo split milestones and pre-requisite course flags added a unit test in lmd and fixed broken tests removed extra line updates to use milestone app api instead of signals fixed broken test making pre-requisite ddl property of settings page user dashboard messaging changes after marco's feedback collect milestone at the time user passed course merged with tip and made changes to comply with new api removed obsolete items removed line break updates after changes in parent branch changes based on feedback
ziafazal
force-pushed
the
ziafazal/collect-user-milestones
branch
from
January 8, 2015 07:36
4a113c8 to
afbf6b9
Compare
ziafazal
force-pushed
the
ziafazal/add-pre-requisite-course-via-milestones-app
branch
2 times, most recently
from
January 8, 2015 10:54
a282e99 to
4d32ca5
Compare
mattdrayer
force-pushed
the
ziafazal/add-pre-requisite-course-via-milestones-app
branch
from
January 8, 2015 21:18
4d32ca5 to
5c1f0e9
Compare
ziafazal
force-pushed
the
ziafazal/add-pre-requisite-course-via-milestones-app
branch
2 times, most recently
from
January 9, 2015 10:17
15279d9 to
18935e4
Compare
Contributor
Contributor
Author
|
Yeah closing it since it is already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mattdrayer @chrisndodge these are the changes related to milestone collection and gating access to courses with pre-requisites.