Add new setting to cms project - #645
Conversation
There was a problem hiding this comment.
TECH_SUPPORT_EMAIL isn't defined in cms.envs.aws or cms.envs.common; it's in lms.envs.common. I would add TECH_SUPPORT_EMAIL to the things you already import from lms.envs.common into cms.envs.common
There was a problem hiding this comment.
That's what I'm not clearly understanding. In cms/envs/common.py we have:
import lms.envs.common
Shouldn't that pick up the TECH_SUPPORT_EMAIL setting?
There was a problem hiding this comment.
Added explicit definition in cms/envs/common.py
There was a problem hiding this comment.
actually not, you'd either have to specify "lms.envs.common.TECH_SUPPORT_EMAIL" or say "from lms.envs.common import TECH_SUPPORT_EMAIL". Importing a module doesn't add its namespace to your current one; you do that with the "from import " syntax.
Of course explicit definitions work too!
There was a problem hiding this comment.
probably cleanest to change cms/envs/dev line 29 to "from lms.envs.common import USE_TZ, TECH_SUPPORT_EMAIL".
|
@adampalay is this what you had in mind? I kept the override in aws.py in case there wanted to be a configurable means to change this in prod. |
|
yep! 👍 |
…nfig Add new setting to cms project
quick wording change
Merge pull request #645 from edx-solutions/rc/2016-03-09
…ck-sha Update free text xblock sha
2 participants
@adampalay @jzoldak can you review. We'll need to get this into this week's release.