Awais786/ecom 662 decline error - #6430
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Just to make sure this accurately simulates the response from the payment processor, this method should delete auth_amount when the decision is not "ACCEPT"
Contributor
Author
There was a problem hiding this comment.
@wedaly I made this change.Please check it.
Contributor
There was a problem hiding this comment.
Hmm, still not seeing it. It looks like _signed_callback_params() is still returning a dictionary with an auth_amount key.
Contributor
Contributor
There was a problem hiding this comment.
Suggested text:
We're sorry, but this payment was declined. The items in your shopping cart have been saved.
If you have any questions about this transaction, please contact us at {email].
awais786
force-pushed
the
awais786/ECOM-662-decline-error
branch
from
January 5, 2015 10:28
948f80c to
326ad9e
Compare
Contributor
|
👍 once my last comment is addressed. |
Adding decline button in fake payment page. In of case ERROR, CANCEL, and DECLINE removing auth_amount from test cybersource2 and payment fake.
awais786
force-pushed
the
awais786/ECOM-662-decline-error
branch
from
January 6, 2015 13:25
761d605 to
dfb366a
Compare
awais786
added a commit
that referenced
this pull request
Jan 6, 2015
Awais786/ecom 662 decline error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wedaly Please review the PR.