LMS: Student Notes - View All/Search Final Styling (UX-1331)

[talbs]

This work styles the various states of the aggregated notes view.

---

Known Concerns

• I created this branch from https://github.com/edx/edx-platform/pull/6384, which contains a few base styles/utilities for this work. Once that PR is merged or cherry-picked, this should be rebased and can stand on its own.
• I revised some existing class names that JS methods relied on (and tried to change the JS). @polesye or @tymofij, I need your help correcting tests and proofing the production JS

---

Screengrab - Latest Notes

Screengrab - Notes by Course Structure

Screengrab - Search No Results

Screengrab - Search Blank Error

[talbs]

@clrux, @explorerleslie, and @polesye or @tymofij, here's a PR for https://openedx.atlassian.net/browse/UX-1331.

Note, I've made this work based off of my other open PR's commits. The one commit you should care about for this work is edx@ca5f16f

---

@frrrances, can you review my markup, styling and FED work here?

@polesye and @tymofij ,I've adjusted some markup/JS here that tests may need to be synced up with. Can you take a look to make sure the JS is still good and your tests work?

@explorerleslie, I've attached screengrabs to show states (until all of this work and the previous PR can be put on the feature sandbox). Feel free to review from a Product/overall UX PoV.

@clrux, no action needed, the changes here are just an FYI on what I had to do on the FED and visual design levels of our project.

[talbs]

@frrrances, don't taze me on the RTL stuff yet, bro! Getting a fixup! commit with that stuff in place shortly.

[talbs]

@frrrances, I've added in RTL support for this work and am hands off now until you're done with your review. Let me know if you need help setting up notes locally. This gist really helped with devstack bits, but there are a few more steps in Studio afterwards.

[polesye]

@talbs I thought we're using 4 spaces for indentation.

[talbs]

Apologies - moving this back to the land of quad-spacing!

[polesye]

Unit tests are fixed.

[explorerleslie]

looks good 👍

[frrrances]

Is this latin going to get cleaned up before merge?

[frrrances]

@talbs nice work! code looks good... i couldn't even find much to nit over! can we connect tomorrow so i can get my local set up for UX review?

[talbs]

@frrrances, firstly, I don't know what you have against the Latin language (its not dead, yet!). :P

Thanks for the review, I'll clean up those bits and am happy to help you get set up locally with notes. A few things that will help:

• This config walkthrough gist by @tymofij - https://gist.github.com/tymofij/1cac43f6ecd54bc58773
• Here's a course export you can import to start from - http://cl.ly/1A1k0A0j1V1v

[talbs]

Closing this branch/PR in favor or a fresher one with cherry-picked commits - https://github.com/edx/edx-platform/pull/6471