Clean up front page UI and video elements, remove cruft [OPEN-407, OPEN-358] by sarina · Pull Request #6243 · openedx/openedx-platform

sarina · 2014-12-14T02:57:15Z

Ref: https://openedx.atlassian.net/secure/attachment/14110/default-view-audit.pdf, https://openedx.atlassian.net/browse/OPEN-407

sarina · 2014-12-14T02:58:31Z

The purpose of this change is to remove our stale, early-2012 marketing text from default Open edX instances. Cribbed some text from the apache welcome page and the django welcome page - I'm open to suggestions here.

stephensanchez · 2014-12-15T14:06:05Z

@sarina One quick note (and I may be out of context) I noticed that the wording suggests removing "Honor Code". Maybe this is edx.org specific, but the Honor code is part of the Terms of Service page
https://www.edx.org/edx-terms-service

sarina · 2015-01-05T20:50:34Z

@singingwolfboy @talbs can you please review?

singingwolfboy · 2015-01-05T20:56:46Z

Right now, "and" isn't being translated. Is that OK?

sarina · 2015-01-06T03:34:09Z

@singingwolfboy how's this?

I am having trouble, however, figuring out how to verify if this logic is even working when there is no honor code link present. Noting it down so I remember to look into it tomorrow - I thought i verified the similar logic at L17 and 24 above previously.

Looks good to me.

OK - was able to verify this. Had to actually fully restart my server to see the %if clause take effect.

sarina · 2015-01-06T18:46:05Z

@stephensanchez thanks for pointing out the honor code. I made the open source footer conditionally link to the Honor Code if there's a link present to an Honor Code in the marketing urls map.

sarina · 2015-01-06T18:51:53Z

@singingwolfboy any other review comments?

@nedbat could you please also review this?

singingwolfboy · 2015-01-06T18:56:54Z

👍

talbs · 2015-01-06T18:56:54Z

@sarina, apologies for the delay - I'll be getting to this shortly on my end.

talbs · 2015-01-06T20:07:31Z

NIT: indentation - looks like you might be missing some spaces.

talbs · 2015-01-06T20:08:57Z

@sarina, the HTML and Sass/CSS changes here look good. Thanks much for helping to clean up our Open front door.

👍

nedbat · 2015-01-06T20:33:11Z

This seems mis-indented.

nedbat · 2015-01-06T20:36:23Z

👍 after fixes.

Remove Jobs, News Change "Vision" to "About"

sarina · 2015-01-07T01:30:58Z

last build had Jenkins system failures in a few shards, so rebuilding.

sarina · 2015-01-07T02:58:51Z

failing test is flaky

Clean up front page UI and video elements, remove cruft [OPEN-407, OPEN-358]

sarina reviewed Dec 14, 2014
View reviewed changes

sarina changed the title ~~Clean up front page UI and video elements [OPEN-407]~~ Clean up front page UI and video elements, remove cruft [OPEN-407, OPEN-358] Dec 14, 2014

wedaly force-pushed the master branch from d4de932 to d2b4a6e Compare December 29, 2014 16:20

sarina force-pushed the sarina/default-edx-UI branch 3 times, most recently from e44cd91 to da22aec Compare January 5, 2015 20:50

singingwolfboy reviewed Jan 5, 2015
View reviewed changes

Comment thread lms/templates/footer.html Outdated

singingwolfboy Jan 5, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, "and" isn't being translated. Is that OK?

sarina force-pushed the sarina/default-edx-UI branch from da22aec to e13a722 Compare January 6, 2015 03:32

sarina reviewed Jan 6, 2015
View reviewed changes

sarina force-pushed the sarina/default-edx-UI branch 2 times, most recently from 775a287 to 141a71e Compare January 6, 2015 18:45

talbs reviewed Jan 6, 2015
View reviewed changes

Comment thread lms/templates/index.html Outdated

talbs Jan 6, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: indentation - looks like you might be missing some spaces.

nedbat reviewed Jan 6, 2015
View reviewed changes

Comment thread lms/templates/footer.html Outdated

nedbat Jan 6, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems mis-indented.

sarina force-pushed the sarina/default-edx-UI branch from d7c596d to c83030c Compare January 6, 2015 22:19

sarina added 3 commits January 6, 2015 17:20

Turn off welcome video by default on Open edX LMS index page

ec87a14

Change default welcome from mktg text to Open edX text

6c5542c

Remove "legacy" footer now that new edx footer in place

aa8b895

sarina force-pushed the sarina/default-edx-UI branch from c83030c to 414e050 Compare January 6, 2015 22:24

sarina added 7 commits January 6, 2015 18:26

Clean up default pages for Open edX instances

d6741c7

Remove Jobs, News Change "Vision" to "About"

Remove no-longer-used template

4a2253a

Abstract references to social media accounts

b7a1de1

Organize logic on Find Courses view.

682d3d0

Change Open edX index page bright blue to grey

3a3ab76

Hide Honor Code mentions if site does not have an Honor Code

61e02fa

Clean up default Open edX pages

4fcbcaa

sarina force-pushed the sarina/default-edx-UI branch from 414e050 to 4fcbcaa Compare January 6, 2015 23:27

sarina added a commit that referenced this pull request Jan 7, 2015

Merge pull request #6243 from edx/sarina/default-edx-UI

8af5494

Clean up front page UI and video elements, remove cruft [OPEN-407, OPEN-358]

sarina merged commit 8af5494 into master Jan 7, 2015

sarina deleted the sarina/default-edx-UI branch January 7, 2015 02:58

snyk-bot mentioned this pull request Jul 16, 2020

[Snyk] Fix for 1 vulnerabilities ISMinisterios/edx-platform#10

Open

Uh oh!

Conversation

sarina commented Dec 14, 2014

Uh oh!

sarina Dec 14, 2014

Choose a reason for hiding this comment

Uh oh!

stephensanchez commented Dec 15, 2014

Uh oh!

sarina commented Jan 5, 2015

Uh oh!

singingwolfboy Jan 5, 2015

Choose a reason for hiding this comment

Uh oh!

sarina Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

singingwolfboy Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

sarina Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

sarina commented Jan 6, 2015

Uh oh!

sarina commented Jan 6, 2015

Uh oh!

singingwolfboy commented Jan 6, 2015

Uh oh!

talbs commented Jan 6, 2015

Uh oh!

talbs Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

talbs commented Jan 6, 2015

Uh oh!

nedbat Jan 6, 2015

Choose a reason for hiding this comment

Uh oh!

nedbat commented Jan 6, 2015

Uh oh!

sarina commented Jan 7, 2015

Uh oh!

sarina commented Jan 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants