changing http:// to // on intro video urls - #618
Merged
Conversation
ghost
assigned
Contributor
|
A better solution is to change the URLs to "//...", with no schema at all. Then they will default to the schema used to load the page: http://nedbatchelder.com/blog/200710/httphttps_transitions_and_relative_urls.html |
Contributor
|
I don't know anything about this so I'm not a good reviewer. Ned's blog post seems to make sense, though. |
Contributor
|
+1 to @nedbat's solution |
Contributor
Author
|
@nedbat - that's super cool! Commit amended to reflect feedback! |
…locking video embeds
Contributor
|
👍 looks great! |
caesar2164
added a commit
that referenced
this pull request
Aug 9, 2013
changing http:// to // on intro video urls
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…-tab Feature/victor/hide progress tab
mtyaka
referenced
this pull request
in open-craft/openedx-platform
Feb 10, 2016
…ring Update hash code for xblock mentoring
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 30, 2016
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Mar 30, 2016
…ername-not-fillin Change username does not fill-in openedx#618
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox 23 has started blocking mixed content (https://blog.mozilla.org/tanvi/2013/04/10/mixed-content-blocking-enabled-in-firefox-23/) so the urls should be changed to https. (or "//" as per @nedbat's comment)
Tested manually in firefox by changing http to https in inspector and it worked. I also tested to make sure that my changes work, but they do require db updates to make sure the videos have https in their records...
Laundry list of mentions: @ormsbee, @nedbat, @singingwolfboy