Imports must replace drafts w/ published in split - #6032
Conversation
There was a problem hiding this comment.
Perhaps more correct idea: if the draft represents a change done in dest course, then don't overwrite it. That condition is simply, draft_dest_module.update_version != pub_dest_module.source_version
There was a problem hiding this comment.
Let's run this by @explorerleslie , but I think even in this case the draft should be overwritten. If a module is in draft in the destination course, but is not in the imported course, after importing I'd think the module in the destination course should not be in draft.
There was a problem hiding this comment.
So, I believe old mongo has both this existing bug and fails at "If a module is in draft in the destination course, but is not in the imported course, after importing I'd think the module in the destination course should not be in draft." This fix makes split act the way you're saying.
|
👍 |
There was a problem hiding this comment.
The comment for DIRECT_ONLY_CATEGORIES says "Things w/ these categories should never be marked as version=DRAFT". Why?
|
👍 after test failure resolved. |
4ff5a41 to
f30ad29
Compare
Imports must replace drafts w/ published in split
3 participants
PLAT_299
@adampalay please review & decide whether to add another bug report for old mongo (which does not work)
any(@cpennington @doctoryes @nasthagiri) please review