Skip to content

WIP: Default Studio editing support for xblocks - #6028

Closed
cahrens wants to merge 1 commit into
masterfrom
christina/xblock-editor-support
Closed

WIP: Default Studio editing support for xblocks#6028
cahrens wants to merge 1 commit into
masterfrom
christina/xblock-editor-support

Conversation

@cahrens

@cahrens cahrens commented Nov 21, 2014

Copy link
Copy Markdown

No description provided.

@bradenmacdonald

Copy link
Copy Markdown
Contributor

@cahrens What's the status on this and the development timeline? If the timelines work out I'd like to see if we can find the time and scope to merge the new features from openedx-unsupported/xblock-utils#5 into this branch or as a second PR against edx-platform (especially the alternate UI for List fields that are acting as sets, reusing validation, and distinguishing between explicitly set and default values that are identical).

@cahrens

cahrens commented Mar 3, 2015

Copy link
Copy Markdown
Author

We have no plans to work on this PR in the next month-- I don't know if this work will prioritized in the next quarter.

@andy-armstrong and I had planned to work on this again for last week's hackathon, but instead we worked on feature in development for Q3.

@sarina

sarina commented Mar 3, 2015

Copy link
Copy Markdown
Contributor

@explorerleslie asked me to have Braden sync up with you here, Christina. I think we want to see if there's a way to use the work Braden's doing to help move this along - perhaps that's not possible, but worth looking into. Leslie can add anything if I misunderstood the intention here.

@antoviaque

Copy link
Copy Markdown
Contributor

FYI, the reason openedx-unsupported/xblock-utils#5 was done as a mixin on the XBlock was time constraints, with the assumption that it would likely take significantly more time to get something merged on edx-platform. So we were considering contributing it to edx-platform as a second step, once the deadlines for the Harvard course are secured. I would be happy to see it being used beyond the mentoring XBlock, so happy to go through the extra effort to merge the two approaches, but I would also like to make sure we are able to keep the deadlines - they already look pretty tight, and we still have another set of changes to merge after the current batch. If there is a way to do this in two steps to not block the merge of the mentoring XBlock PR, I would feel infinitely safer about it.

@cahrens

cahrens commented Mar 3, 2015

Copy link
Copy Markdown
Author

As far as this PR, @andy-armstrong and I outlined exactly what needs to be done to get it to a mergeable state. Here are the JIRA tickets that describe the remaining steps:

https://openedx.atlassian.net/browse/TNL-850
https://openedx.atlassian.net/browse/TNL-851

@sarina

sarina commented Mar 4, 2015

Copy link
Copy Markdown
Contributor

@explorerleslie - it seems like the right thing to do is to move forward with Xavier's mixin for the time being - we won't have the time to get this in their timeframe. That's OK with you? I don't fully remember what your concerns were here.

@explorerleslie

Copy link
Copy Markdown

@sarina yes, that's fine. I wanted to make sure we discussed it before moving forward, but given the timeframe I agree with @antoviaque 's two step proposal.

@cahrens

cahrens commented Mar 4, 2015

Copy link
Copy Markdown
Author

@bradenmacdonald and @sarina the mixin is not going into edx-platform, correct? I have no problem with it merging to xblock-utils, but for edx-platform, I want us to take the approach of sharing the existing xmodule field editors (which is what this PR does).

@bradenmacdonald

Copy link
Copy Markdown
Contributor

@cahrens That's right, the mixin is not meant to be merged into edx-platform.

@antoviaque

Copy link
Copy Markdown
Contributor

@sarina @explorerleslie Sounds perfect - thank you!

@cahrens

cahrens commented Mar 9, 2015

Copy link
Copy Markdown
Author

This is out of date at this point. I don't know how much work would be needed in the rebase.

@sarina

sarina commented Mar 9, 2015

Copy link
Copy Markdown
Contributor

@cahrens I think user @kawaguchi-ks may be a bot - I am reaching out to him and others at the company to verify. Please ignore these posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants