Legacy dash cleanup

[sarina]

This PR updates the legacy dashboard by removing all buttons and features that are present on the Instructor Dashboard. The advantage of this PR is making very clear upon inspection what few remaining features need to be ported to the Instructor Dashboard. As follow on pull requests, I would like to encourage those using the few remaining features to submit PRs porting the buttons to the new dashboard and deprecating the functions Legacy Dash in the same way done in this PR.

This also removes a lot of unstable and untested code, which is good for the health of our codebase.

I've added a deprecated class to the dash CSS so we can stylize messages as we see fit.

Screenshots of each Legacy Instructor Dashboard section are here: https://drive.google.com/a/edx.org/folderview?id=0B0jBaSRrrplqU3phdGo1dTZjbGM&usp=drive_web

[sarina]

This will need code review: @adampalay
UX review: @talbs
Product review: @explorerleslie

If we can get this roughly in shape, I will be sure to run it by people at MIT (Ike, Carson) to make sure I'm not removing something that shouldn't be removed.

[adampalay]

👍 , thanks!

[sarina]

@adampalay was just curious if any of the buttons I left have an analogue in the new instructor dashboard. I didn't think they did - but it would be cool to remove as many as possible.

[talbs]

I can help make this a bit more explicit. Also, I'll change this to follow some of our SMACSS principles around stateful class names - https://smacss.com/book/state.

[talbs]

@sarina, I took a quick spin through - this makes sense and I've added some general deprecation styling in to help support you. Looks good from a UX/FED PoV.

👍

[adampalay]

@sarina we could also get rid of "Download CSV of all student grades for this course" in the "data download" tab

[sarina]

Thanks for the feedback @adampalay and the styling @talbs ! I've updated the screenshots in the Google drive folder to reflect the most recent version of this branch.

[adampalay]

👍

[sarina]

Thanks Adam. Need to get @explorerleslie 's feedback and approval before merging

[sarina]

@mhoeber @catong - approved by Product. Could I get someone to quickly review the wording (see the screenshots in the description, or view at http://sarina.m.sandbox.edx.org/courses/edX/DemoX/Demo_Course/legacy_instructor_dash)

[sarina]

@explorerleslie - @shnayder took a look through this at last week's product triage, but he wanted to make sure you had a solid heads up. also need to get Doc to double check the wording.

[catong]

This seems like a duplicate of the line below ("To download student grades"). I would delete this one.

[catong]

For all the redirect messages:

• delete "please" from the instructions
• remove the single quotes around the section names
• Instructor Dashboard should have initial caps.

[catong]

I'd suggest combining redirect messages under each heading wherever possible so that there is only one redirect message under each heading, otherwise it's quite busy and might be confusing.
Minor rewording in this case:
"To view the Gradebook (only available for courses with a small number of enrolled students), visit the Student Admin section of the Instructor Dashboard."

[catong]

Also a thought about the positioning of the messages.
Not to make more work, but it might be less distracting if all messages were below any remaining buttons?
Users might come to a legacy dashboard page, and go to perform an action. If the button is there for their desired action they can click it. If not, any redirect messages are collected below all active buttons in each section. What do you think, @sarina, @explorerleslie @mhoeber?

[catong]

Combine into one message (even though slightly different areas?)
"To manage beta tester roles and cohort groups, visit the Membership section of the Instructor Dashboard"

[catong]

One additional suggestion although it adds work. In some sections where there are multiple redirect messages that cannot be combined because they redirect to different places, it might be better for users if all the redirect messages are moved below the active buttons. That way, if they are using the legacy dashboard to perform the actions, they can more easily see what actions are available, then any redirect messages can be seen below. What do you think @sarina @explorerleslie @mhoeber?
Otherwise, 👍 with suggested edits including combining messages where possible.

[sarina]

@catong I think moving the messages below the active buttons makes a lot of sense and a consistent UI. I've done that, and combined messages as you suggest.

[sarina]

build passed at https://jenkins.testeng.edx.org/job/edx-platform-report/7774/ but had to squash my few fixup review comments.

[sarina]

Failing tests are flaky video tests, and the last build run on this exact branch (pre-commit-squashing, which had no conflicts) passed.

[explorerleslie]

@sarina yes, you get a solid 👍 from me. Thanks!