Don't translate … - #600
Conversation
|
@adampalay Can you review, please? |
|
I'm torn about this: I think translators need to understand that their text is in an HTML context, and then need to understand things like … . The downside of pulling this from the string is that there may be languages where a trailing horizontal ellipsis is not the right way to indicate an operation in progress. I don't know if there are any like that, but in general, translation can involved subtle linguistic concerns that are hard for us to anticipate. |
|
I think it should be translated. At worst it means all the translators have to add … themselves but it gives them the flexibility to indicate ellipsis in a localized way. |
|
Well, whatever we decide, we should be consistent. I made this pull request because I noticed that most of the places that we use that ellipsis on the site, it is outside of translated strings -- these two being the only two exceptions I could see. If we want to put the ellipsis inside the translated string, then someone should make a pull request to change that for all the other situations where we use them. (I'd be happy to make that PR myself, if that's what we decide.) |
|
wow, this commit history looks wonky. Might this have been due to the git error from a few days ago? Rebase, perhaps? |
|
Did we ever come to a decision about this? It would be nice to set a standard one way or the other. |
These three steps don't have to happen all at once. |
Added styles for problems
Merge pull request #600 from edx-solutions/rc/2016-01-06
…x-enrolled-tab Change EnrolledTab enabled condition openedx#600
* karandikar/fix-error-saving-fields: [PLAT-1109] Suppress IntegrityErrors caused by race condition
Proversity/production
- [Bugfix] Fix `local/k8s quickstart` commands when upgrading from an older release (#595). - [Bugfix] Fix running the default exim-relay SMTP server on arm64 (#600). - [Feature] Add `tutor k8s apply` comand, which is a direct interface with `kubectl apply`. - [Feature] Add `openedx-dockerfile-minimal` patch, which you can use to install custom packages and run commands as root in the Docker image.
4 participants
No description provided.