Refrain from accessing country code if country is None - #5086
Merged
Conversation
Contributor
|
Test case? |
rlucioni
force-pushed
the
renzo/fix-embargo-middleware
branch
from
September 5, 2014 14:14
e1622f3 to
8445b70
Compare
Contributor
Author
|
Test case. |
Contributor
|
👍 once tests pass. |
Contributor
|
For the test case, why not add another condition to |
rlucioni
force-pushed
the
renzo/fix-embargo-middleware
branch
from
September 5, 2014 14:31
ce5c972 to
497e9b4
Compare
Contributor
Author
|
@wedaly, good call, I've done that. |
Contributor
|
👍 |
rlucioni
force-pushed
the
renzo/fix-embargo-middleware
branch
from
September 5, 2014 14:58
497e9b4 to
c335913
Compare
Contributor
Author
Contributor
Author
|
The failing test is known to be flaky. I'm taking this to Mergetown. |
rlucioni
pushed a commit
that referenced
this pull request
Sep 5, 2014
Refrain from accessing country code if country is None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for the error we were seeing in the release relating to the embargo middleware. New accounts created after the country column was added (i.e., after January) have an empty string for
country, but old accounts have NULL. @dianakhuang and @wedaly, could you please review this? I'll add the commit reverting the reversion of #4976 once it's available.