Skip to content

Conditionalize external_login_or_signup shib behavior on existence of apache shib vars - #507

Closed
jbau wants to merge 1 commit into
masterfrom
jbau/fix/shib-login-guard
Closed

Conditionalize external_login_or_signup shib behavior on existence of apache shib vars#507
jbau wants to merge 1 commit into
masterfrom
jbau/fix/shib-login-guard

Conversation

@jbau

@jbau jbau commented Jul 26, 2013

Copy link
Copy Markdown

@brianhw @cpennington

As discussed over email

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd use external_domain.startswith('shib:'). @brianhw can you make that change to this PR, since @jbau is on vacation?

@brianhw

brianhw commented Jul 30, 2013

Copy link
Copy Markdown
Contributor

There are several more places that need to check for shibboleth. These changes are included in PR 511.

@cpennington

Copy link
Copy Markdown
Contributor

Closing, as this is obsoleted by #511

chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
Quick workaround on syllabus_present that broke staging
hachiyanagi-ks added a commit to nttks/edx-platform that referenced this pull request Dec 4, 2015
…lete-course-with-assets

Add purge flag in delete_course openedx#411
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
…lment_api_performance

Performance fix for enrollment roster api.
yoann-mroz pushed a commit to weuplearning/edx-platform that referenced this pull request Nov 30, 2020
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants