Only redirect when redirect url is an internal page. - #499
Merged
Conversation
Contributor
|
It would be great to have a test of this somewhere. |
Contributor
|
Studio has the same redirect logic in their login page. Can you update that too? |
Contributor
Author
|
All acceptance tests pass: http://jenkins.edx.org:8080/job/release-acceptance-tests/51/ |
Contributor
There was a problem hiding this comment.
Can this be moved into a common location so that the same function is not duplicated in LMS and CMS code?
Contributor
Author
|
Addressed feedback and verified that acceptance tests are passing: http://jenkins.edx.org:8080/job/release-acceptance-tests/53/ |
Contributor
There was a problem hiding this comment.
I think this RegExp deserves a comment as well -- that the port should be stripped from the end of the authority if it matches the default port for the protocol.
Contributor
|
Just add a few comments, and 👍 |
Contributor
|
👍 |
dianakhuang
added a commit
that referenced
this pull request
Jul 30, 2013
Only redirect when redirect url is an internal page.
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Added optional <wiki> tag to course to specify an alternative wiki page.
diegomillan
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Sep 14, 2016
* stv/oars-rebased: Require instructors to activate account for API Add roster endpoint to enrollment API and update OLI tracking
xavierchan
added a commit
to xavierchan/edx-platform-1
that referenced
this pull request
Mar 23, 2020
feat(hmm): create hmm account by activate
yoann-mroz
pushed a commit
to weuplearning/edx-platform
that referenced
this pull request
Nov 30, 2020
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
REV-2233: The upsell banner now duplicates the sidebar banner. Removing it in favor of the new implementation on course home, but keeping the masquerade message that shows instructors when a learner lost access to the course.
Danyal-Faheem
pushed a commit
to Danyal-Faheem/edx-platform
that referenced
this pull request
Jul 15, 2025
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: ahmed-arb <ahmed-arb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cpennington @brianhw Review, please?