"Graphical Slider Tool" integration into studio - #497
Conversation
ghost
assigned
|
Please remove cms/templates/widgets/graphical_slider_tool-edit.html from PR |
|
Please add comment to css why we need it. |
|
Good to go, as soon as you will address all comments. |
|
@auraz, done. |
|
Sorry, 2 failing tests here: xmodule.tests.test_export.RoundTripTestCase.test_graphicslidertool_roundtrip |
|
Ouch... I'll fix them. My fault. |
|
@chrisndodge, I've fixed tests and solved pep8 issues. |
|
Tried branch. Looks good. @talbs does one of the UI people want to review the CSS edits? |
There was a problem hiding this comment.
Rather than setting these here, I think it would be better to have something like:
@property
def configuration(self):
return stringify_children(html.fromstring(self.data).xpath('configuration')[0])
There was a problem hiding this comment.
@cpennington, thanks for your suggestions. Done.
There was a problem hiding this comment.
Nitpick: per https://edx-wiki.atlassian.net/wiki/display/ENG/Python+Guidelines?src=search, the final ) should be on the next line.
|
@cpennington, done python style fix. |
|
👍 |
"Graphical Slider Tool" integration into studio
…errors Catch errors in module load
…cs_list Fix metrics tab downloads for split mongo courses.
add aes key for cms env
* [feat] Add ID verification Alert to course home if a user has a verified seat, but is in the unverified certificate status state, the certificateStatusAlert will now show a message letting the learner know they need to verify in order to earn a certificate. This does not remove the message about the verification deadline in the right sidebar of the course home.
4 participants
We add new field "data" and remove "render" and "configuration", but we don't add backward compatibility functionality, cause this "blade" have been never used before with Mongo, so we haven't any stored data and everything will work fine.
@auraz, @cpennington, please review