Correctly persist checklist settings.

[peter-fogg]

Incidentally, fixes an acceptance test (which would have caught this
bug) not running. Its step regex was "They are correctly selected
after I reload the page$", which happens to be matched by "I reload
the page$", another step definition. Lettuce seems to arbitrarily pick
between definitions if they both match a step, so it's good to ensure
that each step isn't a sub-regex of another.

[cahrens]

👍 To get this into today's release candidate. However, I think this whole thing about saving before updating metadata is very confusing. @dmitchell said that there is a backlog task to remove this 2 (or 3?) step process, and I am 100% in favor of that.

Also flagging @cpennington so that he is aware of the fallout.

[cahrens]

Also, the point about Lettuce matching regexp statements is a good one. I will generally avoid regexp definitions from now on, as they seem risky.

[dmitchell]

A more robust short-term solution would be to have own_metadata(foo) call
foo.save() before iterating over its _model_data, but that' should alo be a
separate task.

On Mon, Jul 22, 2013 at 3:25 PM, Christina Roberts <notifications@github.com

wrote:

Also, the point about Lettuce matching regexp statements is a good one. I
will generally avoid regexp definitions from now on, as they seem risky.

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/465#issuecomment-21369062
.