Crowdsourced Hints - "0.2 release"

[fephsun]

Applies a bunch of improvements to the crowdsourced hints xmodule.

• Adds support for formula response types. To do this, the formula response has been refactored slightly, to expose some internal functionality.
• Works with rounding tolerances specified in each response type.
• Hint-collecting UI now displays all hints that the user saw on one view.
• Closes numerous 500 errors.
  @rocha

[rocha]

Seems like a test is failing. Can you fix it?

[rocha]

Why not compare_answer? That way is more consistent with the naming of other methods.

[rocha]

I closed the PR accidentally, reopening.

[Slater-Victoroff]

Probably worth holding on to a version of samples.split('@') since you seem to use it a number of times.

[rocha]

@fephsun do you think this branch is ready to be merged? if so, can you fix the tests?

[fephsun]

Actually, can we roll the wizard-style UX into this, as well? I'll push that up in a bit. Just have to fix some pep/pylint errors.

[fephsun]

Just added the new UX. The pep8 and pylint errors aren't in code that I touched, so I think this is good.

[fephsun]

@rocha Merge now?

[rocha]

Let me take a look first. Thanks.

On Wed, Aug 7, 2013 at 9:58 AM, Felix Sun notifications@github.com wrote:

@rocha https://github.com/rocha Merge now?

—
Reply to this email directly or view it on GitHubhttps://github.com/edx/edx-platform/pull/442#issuecomment-22252850
.

[fephsun]

@auraz @vaxXxa
This xmodule is moving under the Blades team soon, so you should take a look at it, and ask me questions about any confusing or bad code that I wrote.

[vasylnakvasiuk]

@fephsun, ok. We will review this code at Monday? Is it ok?

[fephsun]

@vaxXxa Yeah, Monday is fine. Thanks for getting back to me so quickly.

[vasylnakvasiuk]

Please use {} everywhere instead of dict():

In [6]: %timeit dict()
1000000 loops, best of 3: 277 ns per loop

In [7]: %timeit {}
10000000 loops, best of 3: 44.2 ns per loop

[fephsun]

@valera-rozuvan Still waiting for the js/coffeescript review. I will be around until this Wednesday. Afterwards, I think @rocha can answer questions.

[valera-rozuvan]

@fephsun I have looked over the CoffeeScript files. They look good. Can you please look into what is causing the build to be unstable? Otherwise, good to merge 👍

[fephsun]

@valera-rozuvan It's pep8/pylint violations from other peoples' commits. I'll deal with this problem today, and merge.

[Lyla-Fischer]

Congrats! Good luck on the post-deploy support!