Peter fogg/notification stories - #415
Conversation
|
@peter-fogg seems like this build status got stuck. Maybe check in with @wedaly or try to kick off another build?!? |
|
@chrisndodge Just rebased onto master, that should start another build. |
|
@peter-fogg, thanks for the good work.
Assuming, there are no objections to my quick changes, this looks good from my UX/design perspective. 👍 Are there any tests or other infrastructure that needs to be updated? Also, would you want to wait till @cahrens or @singingwolfboy are back for a technical review? |
|
@talbs Thanks -- I was going to wait for one of them to review before merging. |
|
@talbs Also, it seems like the asset delete confirmation should use the Warning type as well, no? https://github.com/edx/edx-platform/pull/432 |
|
@peter-fogg, yes - definitely. That was on my list to make a separate branch/pull request to fix since it didn't pertain to the notification stories you tackled here. Your call on whether to roll it in here or I can keep on with my separate plan. |
|
OK. I've got a PR in already (#432) -- build is failing right now because master is broken, but I'll rebase with those changes when it's all fixed. |
|
I checked out the branch and tested it. Just a minor cleanup-item and a request for an additional test. Otherwise 👍 |
|
One other thing-- make sure all acceptance tests are passing. I was seeing some failures/skipped test points locally (including one of the new tests). |
|
When I run the test cms/djangoapps/contentstore/features/problem-editor.feature, I am getting server errors ("Studio is having trouble saving your work") showing on the page on Save (and I am not seeing "Saving..."). However, the tests all pass, so I guess the changes really are getting persisted.... Can you investigate this? I do not see this issue when interactively doing the same thing. |
|
Had to rebase onto master to fix |
|
👍 Good to merge. I'm seeing the same issue on master locally with problem-editor.feature. |
Peter fogg/notification stories
Feature/victor/start dates
Added threads read to export of discussion participation.
…nslation-for-gacco-cypress Fix translation for enter-course button and help modal (openedx#409)
* stv/devstack/disable-django-pipeline: Disable Django pipeline compression in devstack
add async view to recap instructor dash
add async view to recap instructor dash
tencent video show
[ju/ednx/BC-14] Add org roles
…edx#415) Much of the logic is copied from the course exit certificate states. AA-719
4 participants
Studio YZ, F, and E -- component save/delete, course outline delete, and grading status change notifications.
@singingwolfboy and @cahrens are out for now, but @talbs, could you check out the interactions when you've got a chance?