Ensure no old gems are left behind between test runs. - #3919
Merged
Conversation
Running it beforehand was resulting in a corrupted state if it was the first time bundle install was run.
Contributor
Author
|
@jzoldak @clytwynec - builds were failing if it happened to be the first job a given jenkins-worker has ever run. I've made a change that should work on both old and new workers. Please have a look. |
Contributor
Author
|
@jzoldak @clytwynec Here's output from Jenkins now (in this case, the previous build had run a newer version of sass than the current build is using---the last line is bundle clean): |
Contributor
|
Make sense to me. 👍 |
Contributor
|
👍 |
benpatterson
pushed a commit
that referenced
this pull request
May 30, 2014
Ensure no old gems are left behind between test runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue is thus:
** CC @andy-armstrong on that issue, related to Update SASS ( 3.3.5), Bourbon (4.0.2), Neat (1.6.0) #3462. I'm guessing those deprecation warnings will have to be addressed.
** However, in this second run, we still get the deprecation warnings. This is because the previously-upgraded gems are still left behind in the rbenv.
@jzoldak @clytwynec Can you take a look?