Skip to content

vagrant: Always mount node_modules folder after Vagrant NFS mount - #384

Merged
singingwolfboy merged 1 commit into
openedx:masterfrom
antoviaque:vagrant-mount
Jul 12, 2013
Merged

vagrant: Always mount node_modules folder after Vagrant NFS mount#384
singingwolfboy merged 1 commit into
openedx:masterfrom
antoviaque:vagrant-mount

Conversation

@antoviaque

Copy link
Copy Markdown
Contributor

The /opt/edx/edx-platform/node_modules needs to be always mounted upon a VM boot, after Vagrant has manually mounted the repository code from the host. Since the mount made by Vagrant isn't part of fstab, we wait for /opt/edx/edx-platform to be mounted before mounting its subdirectory.

Issue reported in https://groups.google.com/d/msg/edx-code/FK4I2YmduqI/xrX8s0pD620J

@singingwolfboy

Copy link
Copy Markdown
Contributor

Seems reasonable to me. Thanks for the code, and also for helping out Andrés out!

singingwolfboy added a commit that referenced this pull request Jul 12, 2013
vagrant: Always mount `node_modules` folder after Vagrant NFS mount
@singingwolfboy
singingwolfboy merged commit 5a5b3cf into openedx:master Jul 12, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
antoviaque referenced this pull request in open-craft/openedx-platform Feb 10, 2015
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
…-upstream-user-menu-fix

pushed the unit ribbon in lms courseware to back which brought the us…
xavierchan pushed a commit to xavierchan/edx-platform-1 that referenced this pull request May 5, 2019
Agrendalath pushed a commit that referenced this pull request Aug 18, 2021
This PR updates the lti-consumer-xblock version
to a new commit that contains the backported fix
from openedx/xblock-lti-consumer#150
jbcurtin pushed a commit to jbcurtin/edx-platform that referenced this pull request Jan 31, 2022
This PR updates the lti-consumer-xblock version
to a new commit that contains the backported fix
from openedx/xblock-lti-consumer#150

(cherry picked from commit 9612bad)
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
kiram15 pushed a commit that referenced this pull request Jul 17, 2026
fix: add LTI 1.3 UUID to profile CSV download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants