Skip to content

fix: Course search pill not cleared when text deleted. #37709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 2 commits into from
Dec 3, 2025
Merged

fix: Course search pill not cleared when text deleted. #37709

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0761b8
fix: Course search pill not cleared when text deleted
Asespinel Dec 1, 2025
0f8f5c3
chore: fix spacing
Asespinel Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lms/static/js/discovery/discovery_factory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@
}
listing = new CoursesListing({model: courseListingModel});

dispatcher.listenTo(form, 'search', function(query) {
form.showLoadingIndicator();
search.performSearch(query, filters.getTerms());
dispatcher.listenTo(form, "search", function (query) {
form.showLoadingIndicator();
if (!query || query.trim() === "") {
filters.remove("search_query");
}
search.performSearch(query, filters.getTerms());
});
Comment thread
Asespinel marked this conversation as resolved.

dispatcher.listenTo(refineSidebar, 'selectOption', function(type, query, name) {
Expand Down
Loading