Skip to content

fix: prevent None entrance_exam_minimum_score_pct from breaking CourseOverview sync #37339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UsamaSadiq merged 3 commits into from
Oct 8, 2025
Merged

fix: prevent None entrance_exam_minimum_score_pct from breaking CourseOverview sync #37339

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5f1928
fix: prevent None entrance_exam_minimum_score_pct from breaking Cours…
Abdul-Muqadim-Arbisoft Sep 9, 2025
8f9b8f2
refactor: clean up entrance_exam_minimum_score_pct handling
Abdul-Muqadim-Arbisoft Sep 11, 2025
2968281
test: update entrance exam deletion test to expect default min score
Abdul-Muqadim-Arbisoft Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cms/djangoapps/contentstore/views/entrance_exam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def _delete_entrance_exam(request, course_key):
if course.entrance_exam_id:
metadata = {
'entrance_exam_enabled': False,
'entrance_exam_minimum_score_pct': None,
'entrance_exam_minimum_score_pct': _get_default_entrance_exam_minimum_pct(),
'entrance_exam_id': None,
}
CourseMetadata.update_from_dict(metadata, course, request.user)
Expand Down
9 changes: 9 additions & 0 deletions openedx/core/djangoapps/content/course_overviews/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,15 @@ def _create_or_update(cls, course): # lint-amnesty, pylint: disable=too-many-st
course_overview.entrance_exam_minimum_score_pct = course.entrance_exam_minimum_score_pct

course_overview.force_on_flexible_peer_openassessments = course.force_on_flexible_peer_openassessments
if course.entrance_exam_minimum_score_pct is None:
entrance_exam_minimum_score_pct = float(settings.ENTRANCE_EXAM_MIN_SCORE_PCT)
if entrance_exam_minimum_score_pct.is_integer():
entrance_exam_minimum_score_pct = entrance_exam_minimum_score_pct / 100
course_overview.entrance_exam_minimum_score_pct = entrance_exam_minimum_score_pct
elif isinstance(course.entrance_exam_minimum_score_pct, int):
course_overview.entrance_exam_minimum_score_pct = course.entrance_exam_minimum_score_pct / 100
else:
course_overview.entrance_exam_minimum_score_pct = course.entrance_exam_minimum_score_pct
Comment thread
Abdul-Muqadim-Arbisoft marked this conversation as resolved.
Outdated

if not CatalogIntegration.is_enabled():
course_overview.language = course.language
Expand Down
Loading