Skip to content

chore: remove version constraint on django-simple-history #36814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feanil merged 1 commit into from
Jun 4, 2025
Merged

chore: remove version constraint on django-simple-history #36814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions requirements/constraints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ Django<5.0
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35277
django-oauth-toolkit==1.7.1

# Date: 2024-02-02
# incremental upgrade
django-simple-history==3.4.0
Comment on lines -32 to -34

@robrap robrap May 30, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. The comment isn't really clear about why it was added. @iamsobanjaved - can you shed any light? Can we move forward with this without causing issues?

@awais786 awais786 Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added when we were a few versions behind on django-simple-history, and we plan to upgrade incrementally, version by version.


# Date: 2021-05-17
# greater version has breaking changes and requires some migration steps.
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35276
Expand Down
4 changes: 2 additions & 2 deletions requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ django==4.2.21
# django-push-notifications
# django-sekizai
# django-ses
# django-simple-history
# django-statici18n
# django-storages
# django-user-tasks
Expand Down Expand Up @@ -326,9 +327,8 @@ django-sekizai==4.1.0
# openedx-django-wiki
django-ses==4.4.0
# via -r requirements/edx/bundled.in
django-simple-history==3.4.0
django-simple-history==3.8.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/kernel.in
# edx-enterprise
# edx-name-affirmation
Expand Down
4 changes: 2 additions & 2 deletions requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,7 @@ django==4.2.21
# django-push-notifications
# django-sekizai
# django-ses
# django-simple-history
# django-statici18n
# django-storages
# django-stubs
Expand Down Expand Up @@ -548,9 +549,8 @@ django-ses==4.4.0
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
django-simple-history==3.4.0
django-simple-history==3.8.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
# edx-enterprise
Expand Down
4 changes: 2 additions & 2 deletions requirements/edx/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ django==4.2.21
# django-push-notifications
# django-sekizai
# django-ses
# django-simple-history
# django-statici18n
# django-storages
# django-user-tasks
Expand Down Expand Up @@ -398,9 +399,8 @@ django-sekizai==4.1.0
# openedx-django-wiki
django-ses==4.4.0
# via -r requirements/edx/base.txt
django-simple-history==3.4.0
django-simple-history==3.8.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
# edx-enterprise
# edx-name-affirmation
Expand Down
4 changes: 2 additions & 2 deletions requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,7 @@ django==4.2.21
# django-push-notifications
# django-sekizai
# django-ses
# django-simple-history
# django-statici18n
# django-storages
# django-user-tasks
Expand Down Expand Up @@ -428,9 +429,8 @@ django-sekizai==4.1.0
# openedx-django-wiki
django-ses==4.4.0
# via -r requirements/edx/base.txt
django-simple-history==3.4.0
django-simple-history==3.8.0
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
# edx-enterprise
# edx-name-affirmation
Expand Down