Skip to content

Problem Bank "view" button - #36781

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
tonybusa:problem-bank-view-components
May 22, 2025
Merged

Problem Bank "view" button#36781
bradenmacdonald merged 1 commit into
openedx:masterfrom
tonybusa:problem-bank-view-components

Conversation

@tonybusa

@tonybusa tonybusa commented May 22, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes: openedx/wg-build-test-release#480

This change adds _top target to the view link (seen on the red circle below, ignore the green for this issue) on the Problem Bank component to open separate route outside of iframe.

image

Useful information to include:

  • Which edX user roles will this change impact? "Course Author"

Previous behavior:

Screen Recording 2025-05-21 at 2.02.57 PM

New behavior:

Screen Recording 2025-05-22 at 2.25.34 PM

Supporting information

Original Issue: openedx/frontend-app-authoring#1895

Testing instructions

  1. Create Library:
  • Add 3 Drag and Drop components
  • Publish those components on the library
  1. Create Course:
  • Create Section
  • Create Sub-section
  • Add New unit
    • Add Problem Bank (beta) component within new unit
    • "Add Component" from a content library to this problem bank.
    • Choose the library you created in step 1
    • Select 3 drag and drop components > Add selected components

Once the authoring page loads those new components into the problem bank, you can see and click the "view" button as shown in the video.

Deadline

Teak build-test-release high priority.

Other information

This does not address the other "view" button as mentioned in this ticket for the MFE: openedx/frontend-app-authoring#2007

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 22, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @tonybusa!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 22, 2025
@tonybusa tonybusa changed the title add _top target to view link to open separate route outside of iframe Problem Bank "view" button May 22, 2025
@tonybusa
tonybusa force-pushed the problem-bank-view-components branch from 55de0ec to bf1af3a Compare May 22, 2025 20:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the link in the Problem Bank component to open the view in the top frame rather than within an iframe.

  • The anchor tag for the view link now includes target="_top".

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label May 22, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions May 22, 2025
@bradenmacdonald
bradenmacdonald merged commit d30490e into openedx:master May 22, 2025
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions May 22, 2025
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@tonybusa

tonybusa commented Jun 2, 2025

Copy link
Copy Markdown
Contributor Author

@bradenmacdonald sorry I forgot to backport these changes so I created this PR to do so: #36838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Refuse to connect if user click on "View" button of the Problem blank xblock

6 participants